-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable automatic transition for darp6 #62
base: master
Are you sure you want to change the base?
Conversation
Should probably update the version (Cargo.toml, Cargo.lock, debian/changelog) so this can be tagged after merge |
Updated version and changelog. |
There shouldn't be any issues with Open EC on the darp6 now, and this shouldn't have any noticeable harm while enabling things like the Keyboard Configurator to work without manual transition.
Rebased since #63 also updated the version and changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transition works as expected. This was tested on a darp6 with 64gb of RAM and a 1TB NVMe installed. I tested all keys on both an ANSI and ISO keyboard.
The firmware version installed after the transition is 2021-01-19_d6d37c0 which did pass certification testing in early February, however it does have the slow keyboard at encryption prompt issue which has been fixed fairly recently. I think it would be best to prepare a more recent version of darp6 firmware before we enable the transition for everyone.
I also found that the keyboard configurator does not show the ISO layout, but I don't think that has to block this firmware release.
That's probably a good idea. While it's not the most critical issue, we don't what to automatically update people to a firmware version with a noticeable bug, when we already have a fix for it.
Agreed, since the firmware update would bring the Configurator from not working at all to mostly working (except that one key); as well as bringing support for charge thresholds. |
There shouldn't be any issues with Open EC on the darp6 now, and this shouldn't have any noticeable harm while enabling things like the Keyboard Configurator to work without manual transition.