Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic transition for darp6 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jun 11, 2021

There shouldn't be any issues with Open EC on the darp6 now, and this shouldn't have any noticeable harm while enabling things like the Keyboard Configurator to work without manual transition.

@ids1024 ids1024 requested review from a team June 11, 2021 17:08
@jackpot51
Copy link
Member

Should probably update the version (Cargo.toml, Cargo.lock, debian/changelog) so this can be tagged after merge

@ids1024
Copy link
Member Author

ids1024 commented Jun 11, 2021

Updated version and changelog.

jackpot51
jackpot51 previously approved these changes Jun 11, 2021
There shouldn't be any issues with Open EC on the darp6 now, and this
shouldn't have any noticeable harm while enabling things like the
Keyboard Configurator to work without manual transition.
@ids1024
Copy link
Member Author

ids1024 commented Jun 14, 2021

Rebased since #63 also updated the version and changelog.

Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transition works as expected. This was tested on a darp6 with 64gb of RAM and a 1TB NVMe installed. I tested all keys on both an ANSI and ISO keyboard.

The firmware version installed after the transition is 2021-01-19_d6d37c0 which did pass certification testing in early February, however it does have the slow keyboard at encryption prompt issue which has been fixed fairly recently. I think it would be best to prepare a more recent version of darp6 firmware before we enable the transition for everyone.

I also found that the keyboard configurator does not show the ISO layout, but I don't think that has to block this firmware release.

@ids1024
Copy link
Member Author

ids1024 commented Jul 7, 2021

I think it would be best to prepare a more recent version of darp6 firmware before we enable the transition for everyone.

That's probably a good idea. While it's not the most critical issue, we don't what to automatically update people to a firmware version with a noticeable bug, when we already have a fix for it.

but I don't think that has to block this firmware release.

Agreed, since the firmware update would bring the Configurator from not working at all to mostly working (except that one key); as well as bringing support for charge thresholds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants