pipe in correct env vars when creating app from docker img (#4013)

porter-dev · Nov 22, 2023 · 3a178b9 · 3a178b9
1 parent c0b33d7
commit 3a178b9
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/dashboard/src/main/home/app-dashboard/create-app/CreateApp.tsx b/dashboard/src/main/home/app-dashboard/create-app/CreateApp.tsx
@@ -77,7 +77,7 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
     React.useState<PorterApp | null>(null);
   const [isDeploying, setIsDeploying] = React.useState(false);
   const [deployError, setDeployError] = React.useState("");
-  const [{ variables, secrets }, setFinalizedAppEnv] = React.useState<{
+  const [appEnv, setFinalizedAppEnv] = React.useState<{
     variables: Record<string, string>;
     secrets: Record<string, string>;
   }>({
@@ -254,11 +254,15 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
     projectID,
     clusterID,
     deploymentTargetID,
+    variables,
+    secrets,
   }: {
     app: PorterApp;
     projectID: number;
     clusterID: number;
     deploymentTargetID: string;
+    variables: Record<string, string>;
+    secrets: Record<string, string>;
   }): Promise<void> => {
     await api.createApp(
       "<token>",
@@ -346,6 +350,8 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
             projectID: currentProject.id,
             clusterID: currentCluster.id,
             deploymentTargetID: deploymentTarget.deployment_target_id,
+            variables,
+            secrets,
           });
         }
 
@@ -786,8 +792,8 @@ const CreateApp: React.FC<CreateAppProps> = ({ history }) => {
             await createAndApply({
               app: validatedAppProto,
               source,
-              variables,
-              secrets,
+              variables: appEnv.variables,
+              secrets: appEnv.secrets,
             })
           }
           deploymentError={deployError}