add strong typecheck to pre commit (#3945)

porter-dev · Nov 9, 2023 · ca722ea · ca722ea
1 parent b73b721
commit ca722ea
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/dashboard/package-lock.json b/dashboard/package-lock.json
diff --git a/dashboard/package.json b/dashboard/package.json
@@ -88,7 +88,7 @@
     "build": "NODE_ENV=\"production\" webpack",
     "build-and-analyze": "ENABLE_ANALYZER=true NODE_ENV=\"production\" ./node_modules/webpack/bin/webpack.js",
     "prepare": "cd .. && husky install dashboard/.husky",
-    "lint-staged": "lint-staged"
+    "lint-staged": "tsc --noEmit && lint-staged"
   },
   "devDependencies": {
     "@babel/core": "^7.15.0",
@@ -159,14 +159,14 @@
     "terser-webpack-plugin": "^4.2.3",
     "ts-loader": "^8.0.4",
     "type-fest": "^4.3.1",
-    "typescript": "^4.1.2",
+    "typescript": "^5.2.2",
     "webpack": "^4.44.2",
     "webpack-bundle-analyzer": "^4.4.2",
     "webpack-cli": "^3.3.12",
     "webpack-dev-server": "^3.11.0"
   },
   "lint-staged": {
-    "**/*.{js,ts,jsx,tsx}": [
+    "src/**/*.{js,ts,jsx,tsx}": [
       "eslint --fix",
       "prettier --write"
     ],

diff --git a/dashboard/src/main/home/cluster-dashboard/env-groups/ExpandedEnvGroup.tsx b/dashboard/src/main/home/cluster-dashboard/env-groups/ExpandedEnvGroup.tsx
@@ -1072,7 +1072,6 @@ const EnvGroupSettings = ({
                   label="New env group namespace"
                   placeholder="ex: default"
                 />
-              )}
               <FlexAlt>
                 <Button onClick={cloneEnvGroup}>Clone {envGroup.name}</Button>
                 {cloneSuccess && (

diff --git a/dashboard/tsconfig.json b/dashboard/tsconfig.json
@@ -1,8 +1,6 @@
 {
   "compilerOptions": {
-    "lib": [
-      "ESNext"
-    ],
+    "lib": ["ESNext"],
     "baseUrl": "src",
     "outDir": "./build/",
     "sourceMap": true,
@@ -15,5 +13,7 @@
     "removeComments": true,
     "moduleResolution": "node",
     "strict": true,
-  }
-}
+    "skipLibCheck": true
+  },
+  "exclude": ["node_modules", "build"]
+}