[0.9.0] Set build context default to Dockerfile dir

[anukul]

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Other (please describe): Spec change

Pull request checklist

Please check if your PR fulfills the following requirements:

• If it's a backend change, tests for the changes have been added and go test ./... runs successfully from the root folder.
• If it's a frontend change, Prettier has been run
• Docs have been reviewed and added / updated if needed

What is the current behavior?

Docker build context default is set to repository root

What is the new behavior?

Docker build context default is set to directory containing Dockerfile

Technical Spec/Implementation Notes

TODO: Allow setting build context from dashboard

[abelanger5]

Looks good @anukul, just one minor thing to resolve 👍

[abelanger5]

Is createFull the only method that calls createFromGithub? If so, we can remove this right?

[anukul]

That's right.. fixed, thanks.

[igalakhov]

Hi @anukul - seems like everything is working well! One slight problem is that (as mentioned in issue #1186) the auto buildpack doesn't work for folders for some reason. I get this error specifically:

Error: invalid app path 'src/': evaluate symlink: lstat src: no such file or directory

After some investigation, it seems like this happens due to Docker - I suspect something with symlinks is done to build and the way we pull/store the repository breaks things (note: I tested with absolute paths and that has the same issue). The exact line of code that fails is this one (this is in library code):

if resolvedAppPath, err = filepath.EvalSymlinks(appPath); err != nil {
		return "", errors.Wrap(err, "evaluate symlink")
	}