Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate usage and billing tabs #4596

Merged
merged 7 commits into from
May 6, 2024
Merged

Consolidate usage and billing tabs #4596

merged 7 commits into from
May 6, 2024

Conversation

jusrhee
Copy link
Collaborator

@jusrhee jusrhee commented May 1, 2024

POR-

What does this PR do?

image

image

image

@jusrhee jusrhee changed the title usage tab fe tab fe May 1, 2024
@MauAraujo MauAraujo changed the base branch from master to list-invoices May 2, 2024 22:23
@MauAraujo MauAraujo changed the title tab fe Consolidate usage and billing tabs May 3, 2024
Comment on lines +493 to +496
// Add raw query parameters to the endpoint
if queryParams != "" {
endpoint += "?" + queryParams
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one option here might be to use the URL type, and consolidate path and params into a single arg:

https://pkg.go.dev/net/url

@jusrhee jusrhee merged commit 85b3a00 into list-invoices May 6, 2024
9 checks passed
@jusrhee jusrhee deleted the usage-tab branch May 6, 2024 16:53
MauAraujo added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants