Skip to content

Commit

Permalink
Merge pull request #1383 from porter-dev/ym/gpu_autoscaling_fix
Browse files Browse the repository at this point in the history
fix: remove division by 100 for gpu scaling threshold in umbrella
  • Loading branch information
yosefmih authored Aug 19, 2024
2 parents 129fcca + 1a26875 commit 1345be6
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion applications/web/templates/hpa-blue-green.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
name: gpu_memory_utilization_ratio
target:
type: AverageValue
averageValue: {{ . | div 100.0 }}
averageValue: {{ . }}
{{- end }}
{{- end }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion applications/web/templates/hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
name: gpu_memory_utilization_ratio
target:
type: AverageValue
averageValue: {{ . | div 100.0 }}
averageValue: {{ . }}
{{- end }}
{{- end }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions applications/web/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ autoscaling:
maxReplicas: 10
targetCPUUtilizationPercentage: 50
targetMemoryUtilizationPercentage: 50
targetGPUUtilizationPercentage: 50
targetGPUMemoryUtilizationRatio: 50
targetGPUUtilizationPercentage: 100
targetGPUMemoryUtilizationRatio: 1
behavior:
enabled: false
scaleDown:
Expand Down
2 changes: 1 addition & 1 deletion applications/worker/templates/hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ spec:
name: gpu_memory_utilization_ratio
target:
type: AverageValue
averageValue: {{ . | div 100.0 }}
averageValue: {{ . }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions applications/worker/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ autoscaling:
maxReplicas: 10
targetCPUUtilizationPercentage: 50
targetMemoryUtilizationPercentage: 50
targetGPUUtilizationPercentage: 100
targetGPUMemoryUtilizationRatio: 1
behavior:
enabled: false
scaleDown:
Expand Down

0 comments on commit 1345be6

Please sign in to comment.