adding deposit transactions #3730
Conversation
name.abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/BarclaysPDFExtractor.java
Outdated
Show resolved
Hide resolved
| .match("^[\\d]{2}\\.[\\d]{2}\\.[\\d]{4} (?<date>[\\d]{2}\\.[\\d]{2}\\.[\\d]{4}) " // | ||
| + "(?<note>.{1,36}).+ +" // |
There was a problem hiding this comment.
I think this regulare expression is not good.
There was a problem hiding this comment.
Note seems to have a fixed length (max 36 characters) and is followed by whitespaces. For now it was working in all cases. I will monitor it in the following months.
There was a problem hiding this comment.
Hi. I hope I understood your concerns correctly, that the combination of two '.' followed by each other allow multiple outcomes. For now it was working, but it could also happen, that the first character is catched into 'note'-subgroup and rest is lost.
I updated PR. Did it become worse or better?🤣
BR Christian
|
Hello @christen90 You can also take a look at the new variant of the test cases... --> here <-- Regards |
|
Hello Alex, BR Christian |
…tfolio.git into adds-barclays-visa-pdf-import-deposit
use trim function fixed test case. anonymization changed length of string.
christen90
force-pushed
the
adds-barclays-visa-pdf-import-deposit
branch
from
d8a15ea to
73d0647
Compare
|
Thanks for the updated pull request @christen90 |
Adding support for deposit transactions to Barclays credit card statements.