e2e-test: browser in parallel & enable Currents #5442
+772
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midleman
force-pushed
the
mi/currents-ii
branch
from
bc3126d
to
63d485e
Compare
midleman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the Currents dashboard integration to evaluate the tool’s usefulness.
Additionally, the browser is now configured to run on multiple ports, allowing browser tests to execute in parallel.
I also consolidated matrix runs into a single machine and enabled multiple threads/workers. This adjustment seems to align better with the current setup and is likely more cost-efficient.
QA Notes
I performed numerous test runs to monitor the potential for increased flakiness with parallel workers. The results are promising overall. While I observed some minor flakiness, these issues appear manageable and can be addressed with further adjustments.