Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: console session tests #6372

Merged
merged 48 commits into from
Feb 19, 2025
Merged

e2e-test: console session tests #6372

merged 48 commits into from
Feb 19, 2025

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Feb 14, 2025

Summary

Addresses the following test tickets which adds functionality for sessions:

Updated some of the Problems code as I will be leveraging this very soon (I have a draft) for future session tests.

QA Notes

@:session @:win @:problems @:console

Copy link

github-actions bot commented Feb 14, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:session @:win @:problems @:console

readme  valid tags

@midleman midleman force-pushed the mi/console-sessions-test branch from 487c5a3 to e144351 Compare February 18, 2025 19:48
@midleman midleman force-pushed the mi/console-sessions-test branch from 6bf803c to f82229b Compare February 18, 2025 20:04
@midleman midleman force-pushed the mi/console-sessions-test branch from 407ff36 to 6488c06 Compare February 19, 2025 00:09
@midleman midleman force-pushed the mi/console-sessions-test branch from 6488c06 to 367f945 Compare February 19, 2025 01:04
@midleman midleman force-pushed the mi/console-sessions-test branch from 973889d to c98e672 Compare February 19, 2025 12:25
@midleman midleman force-pushed the mi/console-sessions-test branch from b263360 to 082e894 Compare February 19, 2025 18:39
@midleman midleman marked this pull request as ready for review February 19, 2025 19:22
jonvanausdeln
jonvanausdeln previously approved these changes Feb 19, 2025
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testlabauto
testlabauto previously approved these changes Feb 19, 2025
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just had a question and a comment.

@midleman midleman dismissed stale reviews from testlabauto and jonvanausdeln via 0375669 February 19, 2025 22:00
@midleman midleman force-pushed the mi/console-sessions-test branch from 0375669 to 9fc570b Compare February 19, 2025 22:01
@midleman midleman merged commit b42ee66 into main Feb 19, 2025
8 checks passed
@midleman midleman deleted the mi/console-sessions-test branch February 19, 2025 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants