bug(styles): Actually output the data frame (#1544)

Co-authored-by: Carson Sievert <[email protected]>
posit-dev · Jul 17, 2024 · 9bd9f2d · 9bd9f2d
1 parent a1f0997
commit 9bd9f2d
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 6 deletions.
diff --git a/docs/Makefile b/docs/Makefile
@@ -80,6 +80,9 @@ quartodoc_build_express: $(PYBIN) quartodoc_interlinks
 
 ## Build test API docs
 quartodoc_build_test: $(PYBIN) quartodoc_interlinks
+	$(eval export SHINY_ADD_EXAMPLES=true)
+	$(eval export IN_QUARTODOC=true)
+	$(eval export SHINY_MODE=express)
 	. $(PYBIN)/activate \
 	  && echo "::group::quartodoc build testing docs" \
 	  && quartodoc build --config _quartodoc-testing.yml --verbose \

diff --git a/js/data-frame/index.tsx b/js/data-frame/index.tsx
@@ -724,7 +724,11 @@ const ShinyDataGrid: FC<ShinyDataGridProps<unknown>> = ({
                       // @ts-ignore:next-line
                       key={header.id}
                       colSpan={header.colSpan}
-                      style={{ minWidth: header.getSize() }}
+                      style={{
+                        width: header.getSize(),
+                        // When row numbers are displayed, this value is helpful instead of `width`
+                        // minWidth: header.getSize()
+                      }}
                       scope="col"
                       tabIndex={0}
                       onClick={header.column.getToggleSortingHandler()}

diff --git a/shiny/api-examples/data_frame_styles/app-core.py b/shiny/api-examples/data_frame_styles/app-core.py
@@ -76,10 +76,11 @@
 
 
 app_ui = ui.page_fillable(
-    ui.hr(),
     ui.h2(
         "Custom styles applied to all cells within a data frame ", ui.HTML("&#128075;")
     ),
+    ui.output_data_frame("my_df"),
+    ui.hr(),
     ui.tags.style(
         ui.HTML(
             """
@@ -96,6 +97,7 @@
         )
     ),
     ui.h2("Data Frame with Styles applied to 4 cells"),
+    ui.output_data_frame("hi_df"),
 )
 
 

diff --git a/shiny/www/py-shiny/data-frame/data-frame.js b/shiny/www/py-shiny/data-frame/data-frame.js
diff --git a/shiny/www/py-shiny/data-frame/data-frame.js.map b/shiny/www/py-shiny/data-frame/data-frame.js.map
diff --git a/...ents/data_frame/validate_row_selection_edit_mode/test_validate_row_selection_edit_mode.py b/...ents/data_frame/validate_row_selection_edit_mode/test_validate_row_selection_edit_mode.py
@@ -12,6 +12,7 @@
 def test_validate_row_selection_in_edit_mode(
     page: Page, local_app: ShinyAppProc
 ) -> None:
+    page.set_viewport_size({"width": 1920 * 2, "height": 1080 * 2})
     page.goto(local_app.url)
 
     # Select (and verify) a row. Edit a cell content in that row.
@@ -61,7 +62,9 @@ def test_validate_row_selection_in_edit_mode(
     page.keyboard.press("Escape")
     page.keyboard.press("Enter")
     data_frame.expect_class_state(
-        "editing", row=1, col=5
+        "editing",
+        row=1,
+        col=0,
     )  # Stage column begins to be edited.
 
     # Click outside the table/Press Escape to exit row focus.