Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anticipate htmltools.HTML no longer inheriting from str #1690

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

cpsievert
Copy link
Collaborator

In anticipation of posit-dev/py-htmltools#86

@cpsievert cpsievert force-pushed the html_not_str branch 3 times, most recently from 60d78d0 to a4606c0 Compare September 18, 2024 21:14
@cpsievert cpsievert changed the title Type check fixes in anticipation of htmltools breaking changes Anticipate htmltools.HTML no longer inheriting from str Sep 18, 2024
@cpsievert cpsievert requested a review from schloerke September 18, 2024 22:08
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpsievert cpsievert merged commit 19d711b into main Sep 18, 2024
48 checks passed
@cpsievert cpsievert deleted the html_not_str branch September 18, 2024 22:31
schloerke added a commit to machow/py-shiny that referenced this pull request Sep 23, 2024
* main:
  chore: Fix `langchain_core` test that used a new `Sequence` type (posit-dev#1697)
  tests(input_slider): add kitchensink tests for input_slider (posit-dev#1691)
  chore: More minor type changes in prep for py-htmltools updates (posit-dev#1693)
  chore: Add types and check action for py-htmltools (posit-dev#1692)
  Anticipate `htmltools.HTML` no longer inheriting from `str` (posit-dev#1690)
  tests(input_select): Add kitchensink tests for input_select and input_selectize (posit-dev#1686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants