Don't apply styling intended for inline text to data-suggestion
attribute; better styling for card suggestions
#1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current approach of always applying styling intended for inline text to any
data-suggestion
, you can wind up with unwanted:after
content in situations like:6bc832e takes a fairly aggressive approach of removing basically all of that styling, but it seems like a defensible take given you can add that styling with
.suggestion
Note 6bc832e also adds a bit of special case if a
data-suggestion
is on aui.card()
, which makes something like this possible: