chore: Add done. signal when package installation is completed
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micropip.install() doesn't install extras but apparently it *acts like it does*.
It was pointed out on Discord that the current message approach makes it look like the last installation has hung
gadenbuie
changed the title
done. signal when package installation is completed
cpsievert
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #194 we went back to calling
because otherwise we lose information like the requested package version.
I thought this broke installation of package extras because it appeared that
micropip.install()doesn't actually install the packages listed in an extra.It turns out that extras aren't installed when the main package is already installed. In other words,
micropip.install("shiny[theme]")will not installbrand_ymlandlibsassbecauseshinyis already installed, butmicropip.install("httpx[socks]")will installsocksioalong withhttpxbecausehttpxisn't initially installed.So in the end, this PR mostly just adjusts a few comments and improves the UX of the console message. As pointed out on Discord the messages say
Installing {req} ...and the last message seems to hang. This PR addsdoneto each line when the package install finishes.