Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Mode #2786

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Privacy Mode #2786

merged 2 commits into from
Feb 7, 2024

Conversation

adamcooke
Copy link
Contributor

@adamcooke adamcooke commented Feb 6, 2024

This allows this mode to enabled on a per-server basis. Once enabled, the IP and hostname information will be excluded from the Received headers inserted by Postal when it receives a message.

  • Add appropriate tests for new Postal::ReceivedHeader class

Copy link
Contributor

@catphish catphish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with this. It appears to be RFC compliant and is much more flexible than the existing approach.

@chrisdeeming
Copy link

Interestingly, historically I have only ever removed the IP address from received headers, leaving the HELO name in place. Reasoning being that the IP address is the only bit I care about being private (the hostname is behind Cloudflare anyway).

I guess as long as this won't bite us and still be deemed as spammy without the hostname I'm happy with this as a solution.

Adds support for hiding IP addresses & hostnames associated with clients sending
authenticated mail in to Postal over SMTP and HTTP
This previously removed all Received headers which were sent to the smtp
server when enabled. This is not something that should be happening.
@adamcooke adamcooke merged commit 97a3284 into main Feb 7, 2024
8 checks passed
@adamcooke adamcooke deleted the privacy-mode branch February 7, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants