-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair backup failed (the value of segment_size is greater than 2G) #510
base: master
Are you sure you want to change the base?
Conversation
@funny-falcon ,I see this problem still exists, are there any plans to fix this? |
@funny-falcon |
Currently there are no plans to fix it, since it quite hard due to backward compatibility issues. |
Ah, I see: your patch is quite capable. Ok, let me think once more. |
@funny-falcon ,It seems n_blocks variable type is int ( file->n_blocks = (int) n_blocks) ,postgrespro has already fixed the (xid 32bit) issue, I think no reason why it can't be fixed!,Thank you very much |
If the value of segment_size is greater than 2G, the file length will overflow. In this case, the backup will fail.