Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in gringo options. #487

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

BenKaufmann
Copy link
Contributor

  • GringoApp, ClingoApp, and ClingoLib all provide a set of gringo options. Extract GringoOptions struct and provide common function for registering options with a command-line option group.

Checklist

Please only open Pull Requests against the wip branch

[ ] Have you followed the guidelines in our CONTRIBUTING.md document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you made sure that all tests succeed?

* GringoApp, ClingoApp, and ClingoLib all provide a set of gringo
  options. Extract GringoOptions struct and provide common function
  for registering options with a command-line option group.
@BenKaufmann BenKaufmann requested a review from rkaminsk February 23, 2024 14:22
@rkaminsk
Copy link
Member

Thanks. It looks alright.

@rkaminsk rkaminsk merged commit d84c400 into wip Feb 23, 2024
4 checks passed
@rkaminsk rkaminsk deleted the reduce-option-duplication branch February 23, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants