Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup dev #18

Merged
merged 2 commits into from
Feb 20, 2024
Merged

fix setup dev #18

merged 2 commits into from
Feb 20, 2024

Conversation

MaxOstrowski
Copy link
Member

The dev environment should be able to use the formatters.

@rkaminsk
Copy link
Member

Is there any need to add doc? Sphinx is a rather large dependency that might conflict with the project itself. We can add format variant though.

@MaxOstrowski
Copy link
Member Author

If you are developing, don't you have to maintain the documentation of the changed code too ?
Don't have a strong opinion about it though. Personally sphynx is way too big for my liking and I would replace it completely with something more lightweight.

@rkaminsk
Copy link
Member

If you are developing, don't you have to maintain the documentation of the changed code too ? Don't have a strong opinion about it though. Personally sphynx is way too big for my liking and I would replace it completely with something more lightweight.

Sure, but we have a nox session for this. The idea for the dev environment was more to have the tools available in the editor you are using.

@rkaminsk rkaminsk merged commit 30ce77b into potassco:master Feb 20, 2024
3 checks passed
@MaxOstrowski
Copy link
Member Author

Makes sense then.

@MaxOstrowski MaxOstrowski deleted the setup branch February 21, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants