-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDpypi #26
CDpypi #26
Conversation
Is there any reason to use reusable workflows here? To me it looks like they should fit into one workflow (consisting of multiple jobs). We could parametrize the publishing workflows because they are structurally equivalent. I also have a (messy) example here: https://github.com/potassco/clingo/blob/master/.github/workflows/cibuildwheel.yml. One can have jobs with dependencies. At the very least only the "Build Wheel and source tarball" should be reusable. Furthermore, I would, at least for the release workflow, add a version check. The git version tag and the one in setup.cfg should be identical. This will prevent trivially botched releases. We could even use setuptools-scm to extract the version from the git tag. Unfortunately, I do not see a way to do this nicely for the workflow publishing to test.pypi. In principle, one would not even need multiple jobs because everything can run on the same container. |
Is there any disadvantage of having reusable workflows? I thought it might be easier to extend and maintain (e.g. adding conda, etc...) But I don't have a strong opinion about it. This is the first time I use reusables. The version check sounds like a useful thing to have. I don't think that the behvaiour for test.pypi.org should be different, no ? You can't overwrite versions there too, no ? |
I find it easier to read everything in one file as long as the file stays short enough. By simply using one job one also needs to start just one container. Deployment will be faster. In clingo, I used multiple jobs because packages had to be build on multiple hosts. The main advantage of reusable workflows is when there is sharing between different workflows. Here we should be able to set up things in away that this is not needed. I'll try to work on this next. Probably, in a small test project using this template that I can deploy to test.pypi. I'll keep you in the loop. |
The deployment section still needs cleanup. |
I was exploring a bit how The current state is here and I am actually quite satisfied with it. Please have a look at the links below: To summarize, I did the following:
Max's proposal was using a reusable workflow to run the tests before the deployment. This can easily be added back. Just let me know what you prefer. |
@MaxOstrowski: let's continue from #31 |
Add continuous deployment on [test.]pypi.org