Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkdocs for the documentation #49

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Mkdocs for the documentation #49

merged 9 commits into from
Dec 5, 2024

Conversation

susuhahnml
Copy link
Collaborator

No description provided.

@susuhahnml susuhahnml requested a review from rkaminsk December 3, 2024 22:46
Copy link
Member

@rkaminsk rkaminsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing. I'll also give it a test run tomorrow.

noxfile.py Outdated Show resolved Hide resolved
@sthiele
Copy link
Member

sthiele commented Dec 4, 2024

@susuhahnml Could we change the directory /docs/reference/api to /docs/reference/API to get the capitalization right?
image

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

@susuhahnml Could we change the directory /docs/reference/api to /docs/reference/API to get the capitalization right?

Please lets stick to all lower case for filenames and urls.

@sthiele
Copy link
Member

sthiele commented Dec 4, 2024

Please lets stick to all lower case for filenames and urls.

Could one use the nav section in the mkdocs.yml file?

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

Please lets stick to all lower case for filenames and urls.

Could one use the nav section in the mkdocs.yml file?

Maybe there is another way to address this. Putting the filename is a bit strange anyway. I would have expected that some meta info is used.

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

I had a look regarding the navigation. It seems like mkdocs uses the filename fore auto-generated navitems and there is no way around. The only way is to specify the full navigation in mkdocs.yml, which is probably what we should do.

EDIT: I simply specified the nav.

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

Another problem is that the frontmatter does not seem to be configured correctly for some pages.

EDIT: the problem seems to be the markdown formatter configured via precommit. We probably have to exclude the folder.

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

@susuhahnml and @sthiele, please have a look whether this works for you.

@rkaminsk
Copy link
Member

rkaminsk commented Dec 4, 2024

One last thing, the blue bar on top in dark mode looks kinda ugly.

@susuhahnml
Copy link
Collaborator Author

I was running away a bit from explicitly writing the navigation so that adding a file was enough and one less step. But I am also ok with keeping it as it gives us more flexibility. Regarding the color, we could use one of the default ones but I would also like to have something unique, since the default is used by many other systems. I also agree it does not look amazing in dark mode.

@susuhahnml
Copy link
Collaborator Author

I changed the color slightly, let me know if you like it better, I imagine that with the whole new branding we would ideally use whatever color is decided there. I also updated the readme with the -- serve for the docs

@rkaminsk
Copy link
Member

rkaminsk commented Dec 5, 2024

@susuhahnml I applied one more tweak to the color. Feel free to refine further. And then just go ahead with merging.

@susuhahnml susuhahnml merged commit 5712fc4 into master Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants