Feature: box border sides #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edzillion thanks so much for the PR! sorry it's been so long since you submitted it. I've been toying with scrolling in my head (as you observed with the unused var) and your instinct for how it works more or less matches my thoughts- I'd be curious to see your approach- I'm leaning toward rendering all content naively out to an image and just grabbing a crop based on scroll offset, with possible optimizations in the future. As for this PR- I think it's more or less right, but I'm not 100% on how it interacts with borderRadius. Do you have ideas/thoughts/screenshots? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Potch, I really commend your work on this module - it works really well and I started playing around with it and realised it could be used for converting markdown to playdate.
In the process of getting that all working I made a few additions to the playout code - I will add them as separate PRs so that you can evaluate them separately.
(this one) Adding
borderLeft,borderRight,borderTopandborderBottomproperties to theBoxelement. This allows me to mimic markdown blockquote styling using a left border only. Settingborderwill override these props.Allowing scrolling, which scrolls in the direction of the
directionproperty of therootbox node. I have this working reasonably well, it has issues withflexelements when the parent hasn't got a set or inheritedwidthormaxWidthbut that makes sense to me. I noticed you had an unused propertyscrollso perhaps you've thought about this already. I will clean that code up and make a separate PR for it unless you have any objections.Also potentially some small changes to allow better encapsulating of modules based on playout.