BabyBear with only Plonky3 changes #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Aug 15, 2024
…ear-params-2 merging into main
…ear-params-2 adding changes from main
Schaeff
reviewed
Aug 21, 2024
Schaeff
force-pushed
the
babybear-params-2
branch
from
bd35465
to
928317f
Compare
…#1721) Unfortunately this requires unsafe, but a pretty tame one. --------- Co-authored-by: schaeff <[email protected]>
|
fixed conflicts |
|
running p3 bb composite on two tests |
Schaeff
requested changes
Sep 6, 2024
plonky3/src/baby_bear.rs
Outdated
| impl FieldElementMap for BabyBearField { | ||
| type Config = StarkConfig<MyPcs, FriChallenge, FriChallenger>; | ||
| fn to_p3_field(&self) -> Plonky3Field<Self> { | ||
| BabyBear::from_canonical_u32(self.to_integer().try_into_u32().unwrap()) |
There was a problem hiding this comment.
This does not need to go through integers, as our BabyBearField type wraps a p3 babybear element. Opened #1761
|
I think |
done |
Schaeff
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BabyBear params to Plonky3 crate.