Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plonky3 keccak optimization #2089

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft

Plonky3 keccak optimization #2089

wants to merge 38 commits into from

Commits on Sep 13, 2024

  1. messed up commit history again...

    @qwang98
    qwang98 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2784378 View commit details
    Browse the repository at this point in the history

  2. test passed'

    @qwang98
    qwang98 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e96fca7 View commit details
    Browse the repository at this point in the history

  3. fixed comments'

    @qwang98
    qwang98 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3f0a7a8 View commit details
    Browse the repository at this point in the history

  4. used unchagnd api

    @qwang98
    qwang98 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6c82727 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. just to rerun CI

    @qwang98
    qwang98 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    f4b3376 View commit details
    Browse the repository at this point in the history

  2. minor

    @qwang98
    qwang98 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a0feb54 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into plonky3-keccak-new-new

    @qwang98
    qwang98 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    628eb79 View commit details
    Browse the repository at this point in the history

  4. removed reverse

    @qwang98
    qwang98 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6cba5dc View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fix

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    98a6ea2 View commit details
    Browse the repository at this point in the history

  2. example for chris

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    79045b0 View commit details
    Browse the repository at this point in the history

  3. not the pil

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    49e2670 View commit details
    Browse the repository at this point in the history

  4. some failed attempts of adapting to nested array

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    29a203d View commit details
    Browse the repository at this point in the history

  5. all fixed

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    66ad3af View commit details
    Browse the repository at this point in the history

  6. remove txt

    @qwang98
    qwang98 committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6a0de54 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. added keccakf to test pipeline

    @qwang98
    qwang98 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    73c608d View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. fix from georg

    @qwang98
    qwang98 committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0bfc318 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. POC for keccak memory

    @qwang98
    qwang98 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d36392c View commit details
    Browse the repository at this point in the history

  2. deleted unwanted

    @qwang98
    qwang98 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ce1e6ad View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into plonky3-keccak-memory-new

    @qwang98
    qwang98 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1b9975a View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Merge branch 'main' into plonky3-keccak-memory-new

    @qwang98
    qwang98 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    03d502a View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. revamped memory machine; still have bugs in witgen

    @qwang98
    qwang98 committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f51f03a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. modified memory address calculation to start from final step latch ro… 

    …w, but still won't work due to not enough auto witgen passes for memory read and write
    @qwang98
    qwang98 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    256c9a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. keccak memory works fully

    @qwang98
    qwang98 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    205b51a View commit details
    Browse the repository at this point in the history

  2. added detailed comments on methodology and efficiency

    @qwang98
    qwang98 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b0499e9 View commit details
    Browse the repository at this point in the history

  3. removed outdated memory submachine tests

    @qwang98
    qwang98 committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    56cefaa View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. addressed all comments

    @qwang98
    qwang98 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3a15b65 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into plonky3-keccak-memory-new

    @qwang98
    qwang98 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    061c256 View commit details
    Browse the repository at this point in the history

  3. created address_inc_cond function that uses increment_ptr; witness ge… 

    …neration time is similar as using links to add_sub
    @qwang98
    qwang98 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    0bda79a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. moved pointer coinstraints to addr_h and addr_l columns

    @qwang98
    qwang98 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fa8a4cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into plonky3-keccak-memory-new-new

    @qwang98
    qwang98 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2f65fb9 View commit details
    Browse the repository at this point in the history

  3. updated pipeline

    @qwang98
    qwang98 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    931a5d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. fixed high degree

    @qwang98
    qwang98 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c6dd8fd View commit details
    Browse the repository at this point in the history

  2. merge main

    @qwang98
    qwang98 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fbd45ca View commit details
    Browse the repository at this point in the history

  3. weird witgen bug emerged again

    @qwang98
    qwang98 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d12fa46 View commit details
    Browse the repository at this point in the history

  4. successful calculation of input and output addresses using inverse an… 

    …d carry; correct calculation of first round values; however witgen stopped by the bug 'we have been stuck in the same row for 100 rounds'; i suspect that if we set this parameter higher, we can solve the bug, but am not sure how to do that
    @qwang98
    qwang98 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    67414af View commit details
    Browse the repository at this point in the history

  5. changing MAX_ROUNDS_PER_ROW_DELTA to 102 or above solves the bug and … 

    …tests all pass
    @qwang98
    qwang98 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    11972db View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. removed print statement due to CI error

    @qwang98
    qwang98 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    06d40f4 View commit details
    Browse the repository at this point in the history

  2. delete unrelated output

    @qwang98
    qwang98 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    5ad8bec View commit details
    Browse the repository at this point in the history