fix nightly tests #2115
fix nightly tests #2115
Conversation
leonardoalt
force-pushed
the
fix-nightly
branch
from
7f57646
to
ea52379
Compare
| @@ -879,7 +879,7 @@ namespace main_vm(64..128); | |||
| fn permutation_instructions() { | |||
| let expected = r#"namespace main(128); | |||
| let _operation_id; | |||
| query |__i| std::prover::provide_if_unknown(_operation_id, __i, || 13); | |||
| query |__i| std::prover::provide_if_unknown(_operation_id, __i, || 9); | |||
There was a problem hiding this comment.
these were caused by changing the asm test
| .collect::<Vec<_>>() | ||
| .into_iter() | ||
| .max() | ||
| .unwrap(); |
There was a problem hiding this comment.
this function is called for both Composite and Mono proofs, and it assumed all degrees were unique ranges before. This now takes the max of all max degrees for the halo2 setup
| instr or X, Y -> Z link ~> Z = bin.or(X, Y); | ||
| instr or_into_B X, Y link ~> B' = bin.or(X, Y); |
There was a problem hiding this comment.
unfortunately Halo2 has a bug somewhere and we can't do this.
This is testes in other places (including RISCV tests) with witgen
There was a problem hiding this comment.
is it possible to disable halo2 for the test instead?
There was a problem hiding this comment.
we still want to run halo2 proofs for these tests to test permutations between machines
There was a problem hiding this comment.
But do we test the previous functionality somewhere else?
There was a problem hiding this comment.
language/compiler/witgen wise yes, the RISCV machine has this stuff and more
| instr or X, Y -> Z link ~> Z = bin.or(X, Y); | ||
| instr or_into_B X, Y link ~> B' = bin.or(X, Y); |
| // instructions activating multiple permutations | ||
| instr add_one X -> Y | ||
| link ~> B = arith.add(X, 2) | ||
| link ~> Y = arith.sub(B, 1) |
There was a problem hiding this comment.
same here and below re halo2
pipeline/src/test_util.rs
Outdated
| .collect::<Vec<_>>() | ||
| .into_iter() |
There was a problem hiding this comment.
| .collect::<Vec<_>>() | |
| .into_iter() |
Does this not work?
There was a problem hiding this comment.
you pasted the same code
There was a problem hiding this comment.
ah read it wrong, the suggestion is only removal, let me check
No description provided.