Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not observe machines that were removed at runtime #2127

Merged
merged 2 commits into from
Nov 22, 2024
Merged

do not observe machines that were removed at runtime #2127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11bac0a
do not observe machines that were removed at runtime
leonardoalt Nov 21, 2024
8b51640
review
leonardoalt Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/fibonacci/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ use powdr::Session;
fn main() {
env_logger::init();

let n = 21;
let n = 22;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause one more chunk

let mut session = Session::builder()
.guest_path("./guest")
.out_path("powdr-target")
.chunk_size_log2(18)
.build()
// Compute Fibonacci of 21 in the guest.
.write(1, &21);
.write(1, &n);

// Fast dry run to test execution.
session.run();
Expand Down
15 changes: 9 additions & 6 deletions plonky3/src/prover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,14 +474,17 @@ where

// observe the parts of the proving key which correspond to the sizes of the tables we are proving
if let Some(proving_key) = proving_key {
for commitment in proving_key
proving_key
.preprocessed
.iter()
.map(|(name, map)| &map[&multi_table.tables[name].degree].commitment)
{
challenger.observe(commitment.clone());
}
};
.filter_map(|(name, map)| {
multi_table
.tables
.get(name)
.map(|table| &map[&table.degree].commitment)
})
.for_each(|commitment| challenger.observe(commitment.clone()));
}

multi_table.observe_instances(challenger);

Expand Down