Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline tests when no features are passed #2132

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Schaeff
Copy link
Collaborator

@Schaeff Schaeff commented Nov 22, 2024

cargo test -p powdr-pipeline

currently fails because it expects panics which cannot happen if the features are off.

This PR fixes it.

@Schaeff Schaeff marked this pull request as ready for review November 22, 2024 13:11
Copy link
Member

@chriseth chriseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chriseth chriseth added this pull request to the merge queue Nov 22, 2024
Copy link
Collaborator

@georgwiese georgwiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into main with commit 078a428 Nov 22, 2024
14 checks passed
@chriseth chriseth deleted the fix-pipeline-tests-with-no-features branch November 22, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants