add piTokenCallback to PowerIndexRouter.sol #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
==========================================
- Coverage 84.18% 83.82% -0.37%
==========================================
Files 11 11
Lines 569 581 +12
Branches 95 99 +4
==========================================
+ Hits 479 487 +8
- Misses 90 94 +4
Continue to review full report at Codecov.
|
eMarchenko
reviewed
May 3, 2022
contracts/PowerIndexRouter.sol
Outdated
| @@ -766,6 +794,7 @@ contract PowerIndexRouter is PowerIndexRouterInterface, PowerIndexNaiveRouter { | |||
| { | |||
| require(_reserveRatioPct <= HUNDRED_PCT, "RR_GREATER_THAN_100_PCT"); | |||
| expectedStakeAmount = getExpectedStakeAmount(_reserveRatioPct, _leftOnPiToken, _totalStakedBalance, _share); | |||
| expectedStakeAmount = expectedStakeAmount.add(_addToExpectedStakeAmount.mul(_share).div(1 ether)); | |||
There was a problem hiding this comment.
It seems that _addToExpectedStakeAmount value is processed incorrectly, as this line doesn't account for reserve %.
In this case consider adding _addToExpectedStakeAmount value to either _leftOnPiToken of _totalStakedBalance at the line above.
defi-dev
force-pushed
the
torn-connector-audit-fixes
branch
from
ac00a61 to
283320c
Compare
defi-lead
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.