Bug #525 - optimise rendering of select options. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per fix, push each rendered element into an array which we then pass to $.fn.add in one go - more efficient. Add test to ensure that add only gets called once.
|
This fix works great. Hope the pull request got approved soon. |
philfreo
reviewed
Oct 17, 2016
| @@ -221,18 +221,18 @@ Form.editors.Select = Form.editors.Base.extend({ | |||
| var optgroup = $("<optgroup>") | |||
| .attr("label",option.group) | |||
| .html( this._getOptionsHtml(option.options) ); | |||
| html = html.add(optgroup); | |||
| html[html.length] = optgroup[0]; | |||
There was a problem hiding this comment.
why not say html.push(optgroup[0])?
For adding to array, use '[].push' instead of '[arr.length] ='
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per fix, push each rendered element into an array which we
then pass to $.fn.add in one go - more efficient.
Add test to ensure that add only gets called once.