Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serveur returns 204 on non existing child node (instead of 404) #39

Open
jonenst opened this issue Mar 19, 2020 · 1 comment
Open

serveur returns 204 on non existing child node (instead of 404) #39

jonenst opened this issue Mar 19, 2020 · 1 comment

Comments

@jonenst
Copy link
Contributor

jonenst commented Mar 19, 2020

  • Do you want to request a feature or report a bug?
    Bug

  • What is the current behavior?
    The server returns 204 (Sucess, no content) when getting "fileSystems/{fileSystemName}/nodes/{nodeId}/children/{childName}" and it doesn't exist

  • What is the expected behavior?
    It should return a 404

  • What is the motivation / use case for changing the behavior?
    Respecting the http status code meanings. This improves API understability and reduce the surprise effect

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@jonenst
Copy link
Contributor Author

jonenst commented Mar 19, 2020

Also the API is documented in swagger with

@ApiResponse(code = 404, message = "No child node for nodeId")

but actually returns a 204.

yichen88 added a commit that referenced this issue Mar 23, 2020
yichen88 added a commit that referenced this issue Mar 23, 2020
mathbagu pushed a commit that referenced this issue Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant