Fix response status if not found (#39) #40
Conversation
Signed-off-by: yichen88 <[email protected]>
| if (status == Response.Status.OK) { | ||
| return Optional.of(readEntityAndLog(response, entityType)); | ||
| } else if (status == Response.Status.NO_CONTENT) { | ||
| if (status == Response.Status.NO_CONTENT || status == Response.Status.NOT_FOUND) { | ||
| LOGGER.trace(" --> null"); | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Why do you remove the INTERNAL_SERVER_ERROR case ?
There was a problem hiding this comment.
and the UnexpectedResponse case ?
There was a problem hiding this comment.
these cases are still checked in readEntityIfOk().
There was a problem hiding this comment.
Ah yes sorry, didn't see it.
| if (status == Response.Status.OK) { | ||
| return Optional.of(readEntityAndLog(response, entityType)); | ||
| } else if (status == Response.Status.NO_CONTENT) { | ||
| if (status == Response.Status.NO_CONTENT || status == Response.Status.NOT_FOUND) { |
There was a problem hiding this comment.
Maybe add a comment that the NO_CONTENT is for backwards compatibility with afs-server < version XX
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: yichen88 <[email protected]>
yichen88
force-pushed
the
fix_not_found_api
branch
from
eeb6745 to
62f3203
Compare
|
Thanks, sorry for the delay ! |
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: yichen88 [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#39
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)