-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean code and fix sonar issues #174
Merged
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3d47d3e
JwtTokenNeededFilter : skipTokenValidityCheck becomes final
rolnico c5646a2
Clean Utils
rolnico 3aff3ea
Create SafeLogger class and use it
rolnico 60ae956
add comment
rolnico 1e520f0
clean EventsTest
rolnico 3ac12fc
use regex: !([\w().]+)\.isPresent\(\)
rolnico 405bf9f
clean NodeInfoTest
rolnico c0e845a
remove method same as parent
rolnico c38bef2
clean ActionScriptTest
rolnico c2075cf
replace ImmutableList.of with List.of
rolnico 01a2249
clean import and some checkstyle
rolnico a7a0dda
clean part of AppData
rolnico c93e1ab
clean part of AppFileSystem
rolnico 076cb46
clean part of AppFileSystemTool
rolnico 2a79c7f
clean LocalTaskMonitor
rolnico 39fd6aa
clean AbstractProjectFileTest
rolnico adc251b
start to clean AfsBaseTest
rolnico 8f3d077
clean AfsBaseTest
rolnico 324054a
clean LocalTaskMonitorTest
rolnico d6a4528
add deprecation date on AbstractModificationScript
rolnico 83a575c
clean AbstractScript
rolnico 0c8440a
clean ImportedCaseTest
rolnico ddc7f6c
clean ModificationScriptTest + create GenericScriptTest
rolnico 5dce23d
clean GenericScriptTest
rolnico 833357a
clean TestImporter
rolnico f32459f
clean VirtualCaseTest
rolnico aa1b57d
clean LocalAppFileSystemConfigTest
rolnico 61bd6dd
clean LocalAppFileSystemProviderTest
rolnico ea9ffd8
clean LocalAppStorageTest
rolnico 4a1398b
clean some classes
rolnico a3f072a
clean NodeGenericMetadataTest
rolnico c7552b7
clean NodeInfoTest
rolnico 47bb97e
clean UtilsTest
rolnico 42cd73e
clean StorageChangeTest
rolnico d09994b
clean NodeEventTest
rolnico ed8ce3d
add RemoteAppFileSystemProviderTest
rolnico f284fe9
make ExceptionDetail a record and add ExceptionDetailTest
rolnico 29fddac
remove CodeCoverageTest fake classes
rolnico 35396ae
Merge branch 'main' into nro/fix_sonar_issues
rolnico 8afa671
remove public modifier
rolnico 17212a0
test on MapDbAppStorageTest
rolnico 59ce99f
add tests
rolnico c0a2b88
fix import
rolnico 6de16e1
fix imports
rolnico 8094c28
disable test
rolnico 4f77233
remove modifier
rolnico 99c739c
Merge branch 'main' into nro/fix_sonar_issues
rolnico d685d8a
revert modifications on Utils.unzip as they will be done in another PR
rolnico 8e4c15a
changed comment on AbstractModificationScript deprecation
rolnico 8bc7f5b
remove test until it works
rolnico File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me why the test fails at the moment...