Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Utils.unzip method #175

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Rework Utils.unzip method #175

wants to merge 5 commits into from

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented Feb 24, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Feature / Quality

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?
The method raises the issue:

Make sure that expanding this archive file is safe here.
Expanding archive files without controlling resource consumption is security-sensitive java:S5042

What is the new behavior (if this is a feature change)?
The issue is still there but the method is more secure according to Sonar, and therefore would be considered a false positive

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Nicolas Rol <[email protected]>
@rolnico rolnico requested a review from olperr1 February 24, 2025 17:01
@rolnico rolnico self-assigned this Feb 24, 2025
@rolnico rolnico mentioned this pull request Feb 24, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants