Add orphan node check #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yichen88 <[email protected]>
yichen88
force-pushed
the
fsck_orphan_child
branch
from
e6c83d4 to
155edac
Compare
sylvlecl
requested changes
May 26, 2021
| statements.add(delete().from(CHILDREN_BY_NAME_AND_CLASS) | ||
| .where(eq(ID, fakeParentId))); | ||
| issue.setRepaired(true); | ||
| issue.setResolutionDescription("Delete row and its parent row"); |
There was a problem hiding this comment.
We can provide a more explicit message like "Deleted node [name=, id=] and reference to absent node [id=]"
| .setDescription(nodeName + "(" + nodeId + ") is an orphan node. Its fake parent id:" + fakeParentId); | ||
| if (options.isRepair()) { | ||
| statements.add(delete().from(CHILDREN_BY_NAME_AND_CLASS) | ||
| .where(eq(ID, nodeId))); |
There was a problem hiding this comment.
This will not be enough, because we need to also delete all associated date, like for a normal node delete:
- delete its children
- delete the associated data
- etc.
afs-cassandra/src/test/java/com/powsybl/afs/cassandra/CassandraAppStorageTest.java
Show resolved
Hide resolved
afs-cassandra/src/main/java/com/powsybl/afs/cassandra/CassandraAppStorage.java
Show resolved
Hide resolved
Signed-off-by: yichen88 <[email protected]>
|
An example table which contains an orphan node. Created by code like final NodeInfo orphanNodes = storage.createNode(UUIDs.timeBased().toString(), "orphanNodes", FOLDER_PSEUDO_CLASS, "", 0, new NodeGenericMetadata());
storage.setConsistent(orphanNodes.getId());
NodeInfo orphanChild = storage.createNode(orphanNodes.getId(), "orphanChild", FOLDER_PSEUDO_CLASS, "", 0, new NodeGenericMetadata());
storage.setConsistent(orphanChild.getId());The fix processing is to find all node's name are null, then use |
sylvlecl
approved these changes
May 31, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yichen88 [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
#87
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)