Always read and write regulating status of ratio tap changer even if …

…loadtapchangingcapabilities is set to false Signed-off-by: RALAMBOTIANA MIORA <[email protected]>
powsybl · Jan 28, 2021 · 994af25 · 994af25
1 parent b38bbf6
commit 994af25
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/AbstractTransformerXml.java b/iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/AbstractTransformerXml.java
@@ -78,9 +78,7 @@ protected static void writeRatioTapChanger(String name, RatioTapChanger rtc, Net
         if (rtc.hasLoadTapChangingCapabilities() || rtc.isRegulating()) {
             context.getWriter().writeAttribute(ATTR_REGULATING, Boolean.toString(rtc.isRegulating()));
         }
-        if (rtc.hasLoadTapChangingCapabilities() || !Double.isNaN(rtc.getTargetV())) {
-            XmlUtil.writeDouble("targetV", rtc.getTargetV(), context.getWriter());
-        }
+        XmlUtil.writeDouble("targetV", rtc.getTargetV(), context.getWriter());
         if (rtc.getRegulationTerminal() != null) {
             TerminalRefXml.writeTerminalRef(rtc.getRegulationTerminal(), context, ELEM_TERMINAL_REF);
         }
@@ -103,10 +101,8 @@ protected static void readRatioTapChanger(String elementName, RatioTapChangerAdd
                 .setTapPosition(tapPosition)
                 .setTargetDeadband(targetDeadband)
                 .setLoadTapChangingCapabilities(loadTapChangingCapabilities)
-                .setTargetV(targetV);
-        if (loadTapChangingCapabilities) {
-            adder.setRegulating(regulating);
-        }
+                .setTargetV(targetV)
+                .setRegulating(regulating);
         boolean[] hasTerminalRef = new boolean[1];
         XmlUtil.readUntilEndElement(elementName, context.getReader(), () -> {
             switch (context.getReader().getLocalName()) {