Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importers: network update API #3148

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zamarrenolm
Copy link
Member

@zamarrenolm zamarrenolm commented Sep 19, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

Once a Network is created, it can not be updated with additional data acquired by Importers.

What is the new behavior (if this is a feature change)?
Allow Importers to update an existing Network with additional data read from external data sources.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

A first use of this new API is implemented in #3182

Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zamarrenolm zamarrenolm marked this pull request as ready for review December 12, 2024 08:49
@zamarrenolm
Copy link
Member Author

Not implement all potential overloads for the Network and Importer update method.
It can be done in this same PR after an agreement on the base change is reached.

Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
73.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant