Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES conversion operational limit tests #3177

Merged
merged 14 commits into from
Feb 11, 2025
Merged

Conversation

rcourtier
Copy link
Member

@rcourtier rcourtier commented Oct 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

New unit tests

What is the current behavior?

OperationalLimit test is using modified conformity network

What is the new behavior (if this is a feature change)?

OperationalLimit test is using simple network

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

The following methods of CgmesConformity1ModifiedCatalog, were removed:

  • microGridBaseCaseBEUndefinedPatl()
  • microGridBaseCaseBELimits()
  • microGridBaseCaseBEMissingLimitValue()
  • miniNodeBreakerLimitsforEquipment()

They were used for unit testing, but they relied on big CGMES files ; this slowed the tests execution. If you still need to use them, you can retrieve the methods at this URL and the corresponding CGMES files in this directory.

Other information:

@rcourtier rcourtier requested a review from zamarrenolm October 11, 2024 11:49
@rcourtier rcourtier force-pushed the operational_limits_test branch from 8961560 to 9856112 Compare October 15, 2024 15:57
@rcourtier rcourtier changed the base branch from main to node_containers_test October 15, 2024 15:58
@rcourtier rcourtier force-pushed the operational_limits_test branch from 41c86e1 to aa54c0f Compare October 16, 2024 09:51
@rcourtier rcourtier changed the title CGMES import operationallimit tests CGMES conversion operationallimit tests Oct 16, 2024
@rcourtier rcourtier changed the title CGMES conversion operationallimit tests CGMES conversion operational limit tests Oct 16, 2024
@rcourtier rcourtier force-pushed the operational_limits_test branch 2 times, most recently from 3e0fb3d to 506923f Compare October 16, 2024 15:06
@rcourtier rcourtier force-pushed the node_containers_test branch from ab05f38 to 235961a Compare October 18, 2024 06:46
@rcourtier rcourtier force-pushed the operational_limits_test branch 2 times, most recently from e21e58d to 5ddd369 Compare October 18, 2024 12:24
@rcourtier rcourtier force-pushed the node_containers_test branch from 0aed252 to 254e52f Compare October 30, 2024 09:23
@rcourtier rcourtier force-pushed the operational_limits_test branch from d247ded to 9600aad Compare October 30, 2024 09:57
@rcourtier rcourtier marked this pull request as ready for review October 30, 2024 09:57
@rcourtier rcourtier force-pushed the node_containers_test branch from 254e52f to 274ff3f Compare October 30, 2024 13:30
Base automatically changed from node_containers_test to main October 30, 2024 14:38
@rcourtier rcourtier force-pushed the operational_limits_test branch 2 times, most recently from 0853dca to ebe5ab4 Compare October 31, 2024 13:50
@rcourtier rcourtier force-pushed the operational_limits_test branch from ebe5ab4 to 2e3bee4 Compare November 8, 2024 10:10
Copy link

sonarqubecloud bot commented Nov 8, 2024

@rcourtier rcourtier force-pushed the operational_limits_test branch from 2e3bee4 to 1bd9e11 Compare January 28, 2025 15:37
@rcourtier rcourtier requested a review from olperr1 January 28, 2025 16:03
@rcourtier rcourtier self-assigned this Jan 28, 2025
@rcourtier rcourtier requested a review from olperr1 January 30, 2025 09:49
@rcourtier rcourtier force-pushed the operational_limits_test branch from fa914cd to e1b770e Compare February 10, 2025 08:10
@olperr1 olperr1 merged commit d62bacd into main Feb 11, 2025
8 checks passed
@olperr1 olperr1 deleted the operational_limits_test branch February 11, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants