Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES conversion switch test #3181

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CGMES conversion switch test #3181

wants to merge 7 commits into from

Conversation

rcourtier
Copy link
Member

@rcourtier rcourtier commented Oct 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
New unit tests

What is the current behavior?
Switch tests are using modified conformity networks

What is the new behavior (if this is a feature change)?
Switch tests are using simple networks

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

The following methods of CgmesConformity1ModifiedCatalog, were removed:

  • miniNodeBreakerLoadBreakSwitch()
  • miniNodeBreakerProtectedSwitch()
  • miniNodeBreakerInternalLineZ0()
  • miniNodeBreakerTerminalDisconnected()
  • microGridBaseCaseNLSwitchWithoutName()
  • microGridBaseCaseNLSwitchTypePreserved()
  • miniGridNodeBreakerSwitchTypePreserved()

They were used for unit testing, but they relied on big CGMES files ; this slowed the tests execution. If you still need to use them, you can retrieve the methods at this URL and the corresponding CGMES files in this directory.

Other information:

@rcourtier rcourtier changed the base branch from main to node_containers_test October 15, 2024 08:31
@rcourtier rcourtier force-pushed the switch_test branch 2 times, most recently from d54c83d to aad604c Compare October 15, 2024 15:45
@rcourtier rcourtier changed the title Switch test CGMES conversion switch test Oct 16, 2024
@rcourtier rcourtier force-pushed the node_containers_test branch from ab05f38 to 235961a Compare October 18, 2024 06:46
@rcourtier rcourtier force-pushed the switch_test branch 2 times, most recently from 88b2b58 to 7261a62 Compare October 18, 2024 11:20
@rcourtier rcourtier force-pushed the node_containers_test branch from 0aed252 to 254e52f Compare October 30, 2024 09:23
@rcourtier rcourtier marked this pull request as ready for review October 30, 2024 09:56
@rcourtier rcourtier force-pushed the node_containers_test branch from 254e52f to 274ff3f Compare October 30, 2024 13:30
Base automatically changed from node_containers_test to main October 30, 2024 14:38
@rcourtier rcourtier requested a review from zamarrenolm October 31, 2024 14:23
…a simpler network file

Signed-off-by: Romain Courtier <[email protected]>
…of a modified conformity file

Signed-off-by: Romain Courtier <[email protected]>
…w a small network instead of an entsoe conformity-modified one

Signed-off-by: Romain Courtier <[email protected]>
…test using a simple network file.

Signed-off-by: Romain Courtier <[email protected]>
…rminals associated to the same topological node).

Signed-off-by: Romain Courtier <[email protected]>
Copy link

sonarcloud bot commented Nov 29, 2024

@rcourtier rcourtier mentioned this pull request Dec 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants