Adder by copy for lines #3208
Open
Adder by copy for lines #3208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naledi EL CHEIKH <[email protected]>
…while copy of line Signed-off-by: Naledi EL CHEIKH <[email protected]>
olperr1
requested changes
Nov 19, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/LineAdderImpl.java
Outdated
Show resolved
Hide resolved
added 5 commits
November 20, 2024 16:46
… and tests Signed-off-by: Naledi EL CHEIKH <[email protected]>
… and tests Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
HugoKulesza
requested changes
Dec 9, 2024
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/Branch.java
Outdated
Show resolved
Hide resolved
iidm/iidm-api/src/main/java/com/powsybl/iidm/network/util/LoadingLimitsUtil.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/SubnetworkImpl.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractCurrentLimitsTest.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractIdenticalLinesTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Naledi EL CHEIKH <[email protected]>
Signed-off-by: Naledi EL CHEIKH <[email protected]>
|
olperr1
added
Breaking Change
olperr1
requested changes
Dec 16, 2024
Comment on lines
+368
to
+375
| return newLine(null, line).setR(line.getR()) | ||
| .setX(line.getX()) | ||
| .setG1(line.getG1()) | ||
| .setG2(line.getG2()) | ||
| .setB1(line.getB1()) | ||
| .setB2(line.getB2()) | ||
| .setVoltageLevel1(line.getTerminal1().getVoltageLevel().getId()) | ||
| .setVoltageLevel2(line.getTerminal2().getVoltageLevel().getId()); |
There was a problem hiding this comment.
The setters should be called in the adder's constructor (or in a utility method, but called in the constructor).
In the current state, these variables are not set when newLine(Line) is called from a subnetwork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
It allows the lines to be initialized from another already existing one.
What is the current behavior?
Lines are not allowed to be duplicated.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Custom IIDM implementation maintainers should add the following method in their
Networkimplementations:LineAdder newLine(Line line).Other information: