Update time domain documentation #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update link to powsybl-dynawo and reference to DLS/ mapping. Add documentation for itools command list-dynamic-simulation-models Signed-off-by: lisrte <[email protected]>
flo-dup
requested changes
Dec 2, 2024
So-Fras
requested changes
Dec 2, 2024
Signed-off-by: lisrte <[email protected]>
Co-authored-by: Sophie Frasnedo <[email protected]> Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
previously requested changes
Dec 10, 2024
| For the moment, the only way to add events to the simulation is through a groovy script. Note that the syntax of this script is specific to each simulator: | ||
| - [Dynawo event model DSL](inv:powsybldynawo:*:*#dynamic_simulation/event-models-dsl) | ||
| The event models may be provided through a groovy script thanks to the `GroovyEventModelsSupplier` provided in powsybl-dynamic-simulation-dsl artifact. Note that the syntax of this groovy script is specific to each simulator. | ||
| See [Dynawo event model DSL](inv:powsybldynawo:*:*#dynamic_simulation/event-models-mapping) for Dynawo specific DSL and others mapping methods. |
There was a problem hiding this comment.
As mentioned in the PR powsybl/powsybl-dynawo#410, could we speak of mapping for events? and for output variables?
|
olperr1
approved these changes
Dec 11, 2024
olperr1
dismissed
flo-dup’s stale review
Seen with @flo-du: OK to merge this PR in this state to have it in the 6.6.0 release. It fixes the documentation and the last comment is not crucial.
olperr1
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Replace Dynawaltz with Dynawo Update link to powsybl-dynawo and reference to DLS/ mapping. Add documentation for itools command list-dynamic-simulation-models * Apply suggestions from code review Signed-off-by: lisrte <[email protected]> Co-authored-by: Florian Dupuy <[email protected]> Co-authored-by: Sophie Frasnedo <[email protected]> (cherry picked from commit 6357a5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Docs update
What is the current behavior?
What is the new behavior (if this is a feature change)?
Replace Dynawaltz provider name with Dynawo
Update link to powsybl-dynawo and reference to DSL/ mapping (PR 410)
Add documentation for itools command
list-dynamic-simulation-modelsDoes this PR introduce a breaking change or deprecate an API?
Other information:
Linked to PR 410