Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access and conversion of contingency voltage level id #3223

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Nov 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

Sided contingencies posses an additional voltage level id attribute but it's only can be accessed via AbstractSidedContingency abstract class.

What is the new behavior (if this is a feature change)?
Add SidedContingencyElement interface for ContingencyElement with voltage level id
Add SidedContingencyElementUtils::getContingencySide in order to get TwoSides enum from SidedContingencyElement

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:

Used in powsybl-dynawo PR 412

…tage level id

Add SidedContingencyElementUtils to get TwoSides enum from SidedContingencyElement

Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte self-assigned this Nov 22, 2024
Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte requested a review from flo-dup November 22, 2024 12:29
Signed-off-by: lisrte <[email protected]>
@Lisrte Lisrte requested a review from flo-dup November 29, 2024 10:07
Copy link

sonarcloud bot commented Dec 2, 2024

@flo-dup flo-dup dismissed geofjamg’s stale review December 2, 2024 09:13

Requested changes addressed

@flo-dup flo-dup merged commit 710047c into main Dec 2, 2024
7 checks passed
@flo-dup flo-dup deleted the sided_contingency_side_conversion branch December 2, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants