Fix fork disconnection #3245
Merged
Fix fork disconnection #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
flo-dup
requested changes
Dec 10, 2024
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/ConnectDisconnectUtil.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerTopologyModel.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractForkConnectDisconnectTest.java
Outdated
Show resolved
Hide resolved
iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractForkConnectDisconnectTest.java
Outdated
Show resolved
Hide resolved
| Switch breaker = network.getSwitch("B_L1_L2"); | ||
|
|
||
| // In this case, B_L1_L2 is open | ||
| breaker.setOpen(true); |
There was a problem hiding this comment.
Could you add the assertFalse(line1.connect()) after?
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
flo-dup
reviewed
Dec 10, 2024
Comment on lines
+240
to
+241
| terminals.forEach(terminal -> assertNotNull(terminal.getBusView().getBus())); | ||
| terminals.forEach(terminal -> assertTrue(terminal.isConnected())); |
There was a problem hiding this comment.
these two lines are equivalent in node breaker topology (at least in the known implementations)
There was a problem hiding this comment.
yes but I preferred to make it obvious and visible since it's part of the issue
Signed-off-by: Nicolas Rol <[email protected]>
|
flo-dup
approved these changes
Dec 10, 2024
alicecaron
approved these changes
Dec 10, 2024
olperr1
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Nicolas Rol <[email protected]> (cherry picked from commit f0482f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #3236
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: