Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGMES: fictitious voltage levels marked as fictitious #3249

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Dec 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?
Fictitious voltage levels marked as non-fictitious

What is the new behavior (if this is a feature change)?
Fictitious voltage levels marked as fictitious

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@flo-dup flo-dup added the bug label Dec 9, 2024
@flo-dup flo-dup requested a review from zamarrenolm December 9, 2024 16:17
Signed-off-by: Florian Dupuy <[email protected]>
@flo-dup flo-dup marked this pull request as ready for review December 10, 2024 10:55
@flo-dup flo-dup requested a review from rcourtier December 10, 2024 10:55
Copy link

sonarcloud bot commented Dec 11, 2024

@olperr1 olperr1 merged commit 77a758d into main Dec 11, 2024
8 checks passed
@olperr1 olperr1 deleted the cgmes_fictitious_vl branch December 11, 2024 09:06
olperr1 pushed a commit that referenced this pull request Dec 11, 2024
* CGMES: fictitious voltage levels are marked as fictitious
* Enrich existing unit test

Signed-off-by: Florian Dupuy <[email protected]>
(cherry picked from commit 77a758d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants