Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the action status badge #3335

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix the action status badge #3335

merged 1 commit into from
Feb 28, 2025

Conversation

olperr1
Copy link
Member

@olperr1 olperr1 commented Feb 25, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Documentation fix

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?

The action status badge references an old URL.

What is the new behavior (if this is a feature change)?
The action status badge references the new URL.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

See issue 8671 from badges/shields:

If you have a github workflow .github/workflows/test.yml
name: Run Tests
You need to update your badge URL from
https://img.shields.io/github/workflow/status/<user>/<repo>/Run%20Tests
to
https://img.shields.io/github/actions/workflow/status/<user>/<repo>/test.yml?branch=main

  • The key change here is that the workflow parameter is now the workflow filename, not the name: defined in yaml
  • We also recommend specifying the branch param in most cases, although it is not required.

Signed-off-by: Olivier Perrin <[email protected]>
@olperr1 olperr1 requested a review from flo-dup February 25, 2025 13:55
@olperr1 olperr1 self-assigned this Feb 25, 2025
@flo-dup flo-dup merged commit eb012ba into main Feb 28, 2025
8 checks passed
@flo-dup flo-dup deleted the fix_badge branch February 28, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants