[CGMES balances adjustment] Migrate from cgmes.extensions.CgmesControlArea to iidm.network.Area #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work with Olivier PERRIN commit investigate tests Add test Migrate from CgmesControlArea to Area Signed-off-by: Hugo SCHINDLER <[email protected]>
OpenSuze
force-pushed
the
feature/remove_cgmes_control_area
branch
from
456fd44 to
4dffd5f
Compare
|
TODO: fix CI |
olperr1
requested changes
Feb 13, 2025
.../test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesVoltageLevelsAreaTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesVoltageLevelsAreaTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesBoundariesAreaTest.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesBoundariesAreaTest.java
Outdated
Show resolved
Hide resolved
.../test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesVoltageLevelsAreaTest.java
Outdated
Show resolved
Hide resolved
entsoe-cgmes-balances-adjustment/src/test/resources/controlAreaWithoutExtension.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Hugo SCHINDLER <[email protected]>
Signed-off-by: Hugo SCHINDLER <[email protected]>
olperr1
requested changes
Feb 14, 2025
...src/test/java/com/powsybl/entsoe/cgmes/balances_adjustment/util/CgmesBoundariesAreaTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hugo SCHINDLER <[email protected]>
# Conflicts: # pom.xml
Signed-off-by: Hugo SCHINDLER <[email protected]>
Signed-off-by: Hugo SCHINDLER <[email protected]>
7 tasks
Signed-off-by: Olivier Perrin <[email protected]>
|
olperr1
approved these changes
Feb 25, 2025
phiedw
approved these changes
Feb 26, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Related to powsybl/powsybl-core#3149
What kind of change does this PR introduce?
Feature
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
CGMES balances adjsutement expects CgmesControlArea but they will be removed in the next Core version.
What is the new behavior (if this is a feature change)?
CGMES balances adjsutement expects Area.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
See Core migration steps
Other information: