-
Notifications
You must be signed in to change notification settings - Fork 4
Zip when archive #266
base: integration
Are you sure you want to change the base?
Zip when archive #266
Conversation
pom.xml
Outdated
@@ -85,7 +85,7 @@ | |||
<slf4j.version>1.7.22</slf4j.version> | |||
<tiwulfx.version>2.0</tiwulfx.version> | |||
|
|||
<powsyblafs.version>3.1.0</powsyblafs.version> | |||
<powsyblafs.version>3.2.0-SNAPSHOT</powsyblafs.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make a PR for that ? As mentionned before, afs and gse are so coupled that I think we should track current snapshot for dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the explicit IOException.
CopyManager should catch any Exception and throw a dedicated CopyPasteException
Archive method produce zip Merge with the PR on afs Signed-off-by: berthaultval <[email protected]> Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]> Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Archive method produce zip
Merge with the PR on afs
Signed-off-by: berthaultval [email protected]
Signed-off-by: berthaultval [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'
to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
When you want unpack, you must select a folder.
What is the new behavior (if this is a feature change)?
Now, when you want unpack, you must select a zip.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)