Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Zip when archive #266

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from
Open

Zip when archive #266

wants to merge 5 commits into from

Conversation

berthaultval
Copy link

@berthaultval berthaultval commented Jan 23, 2020

Archive method produce zip
Merge with the PR on afs

Signed-off-by: berthaultval [email protected]
Signed-off-by: berthaultval [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
When you want unpack, you must select a folder.

What is the new behavior (if this is a feature change)?
Now, when you want unpack, you must select a zip.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@berthaultval berthaultval changed the title New class Utils with zip and unzip method [WIP] Zip when archive Jan 23, 2020
@berthaultval berthaultval changed the title [WIP] Zip when archive Zip when archive Jan 27, 2020
@berthaultval berthaultval self-assigned this Jan 27, 2020
pom.xml Outdated
@@ -85,7 +85,7 @@
<slf4j.version>1.7.22</slf4j.version>
<tiwulfx.version>2.0</tiwulfx.version>

<powsyblafs.version>3.1.0</powsyblafs.version>
<powsyblafs.version>3.2.0-SNAPSHOT</powsyblafs.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a mistake?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Contributor

@pl-buiquang pl-buiquang Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a PR for that ? As mentionned before, afs and gse are so coupled that I think we should track current snapshot for dev.

Copy link
Contributor

@pl-buiquang pl-buiquang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the explicit IOException.
CopyManager should catch any Exception and throw a dedicated CopyPasteException

@pl-buiquang pl-buiquang changed the base branch from master to integration February 10, 2020 16:21
Archive method produce zip
Merge with the PR on afs

Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
Signed-off-by: berthaultval <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pl-buiquang pl-buiquang requested a review from geofjamg February 11, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants