This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Button "filter" to display/pin filter in security analysis result viewer #99
Open
miovd
wants to merge
21
commits into
main
Choose a base branch
from
cse_pin_window
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
changed the title
Button "filter" to display/pin filter in security analysis result viewer
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Oct 30, 2018
miovd
changed the title
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Button "filter" to display/pin filter in security analysis result viewer
Nov 8, 2018
miovd
changed the title
Button "filter" to display/pin filter in security analysis result viewer
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Nov 9, 2018
miovd
changed the title
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Button "filter" to display/pin filter in security analysis result viewer
Nov 12, 2018
miovd
changed the title
Button "filter" to display/pin filter in security analysis result viewer
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Nov 13, 2018
miovd
changed the title
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Button "filter" to display/pin filter in security analysis result viewer
Nov 13, 2018
miovd
changed the title
Button "filter" to display/pin filter in security analysis result viewer
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Nov 16, 2018
miovd
changed the title
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Button "filter" to display/pin filter in security analysis result viewer
Nov 16, 2018
mathbagu
reviewed
Nov 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are at least two cosmetic issues:
- when the filters pane is open, the horizontal scroll bar is partly hidden, so it is impossible to see the columns on the right
- the filters pane opens when the mouse moves on the vertical scrollbar
- the label should probably be Filters/Filtres (plural)
mathbagu
changed the title
Button "filter" to display/pin filter in security analysis result viewer
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Nov 28, 2018
- replace hiddensidepane by borderpane => no opening when scrolling to the right + no hidding of the horizontal scroll - label in plural
miovd
changed the title
[WIP] Button "filter" to display/pin filter in security analysis result viewer
Button "filter" to display/pin filter in security analysis result viewer
Dec 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.