Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #453

Merged
merged 10 commits into from
Jul 24, 2024
Merged

Fix CI #453

merged 10 commits into from
Jul 24, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jul 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Bug fix

What is the current behavior?

  • MacOs build fails on tieline tests due to precision error on xnodeP_1 and xnodeP_2 attributes
  • Sonar is not launched due to Java 11 install

What is the new behavior (if this is a feature change)?

  • MacOs build succeeds
  • Sonar is launched, Java 17 is installed

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@flo-dup flo-dup changed the title Fix macos build Fix CI Jul 23, 2024
flo-dup added 3 commits July 23, 2024 21:07
Signed-off-by: Florian Dupuy <[email protected]>
Copy link

sonarqubecloud bot commented Jul 24, 2024

@flo-dup flo-dup requested a review from olperr1 July 24, 2024 14:25
@flo-dup flo-dup merged commit 77dfcf7 into main Jul 24, 2024
8 checks passed
@flo-dup flo-dup deleted the fix_macos branch July 24, 2024 14:52
flo-dup added a commit that referenced this pull request Jul 25, 2024
* MacOs Tieline unit tests reference fixes iidm v1.0, v1.1, v1.2, v1.3, v1.4
* Use java 17 in QA CI
* Use sonarcloud-github-c-cpp gh action in QA CI
* Use latest actions versions in CI
* Remove sonar.cfamily.build-wrapper-output property

Signed-off-by: Florian Dupuy <[email protected]>
(cherry picked from commit 77dfcf7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants