Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subnetwork support #351

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Subnetwork support #351

wants to merge 20 commits into from

Conversation

obrix
Copy link
Member

@obrix obrix commented Oct 25, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Subnetwork support in powsybl network store implementation

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@obrix obrix force-pushed the subnetwork_support branch from 4400125 to cee760b Compare November 8, 2023 08:48
obrix added 17 commits November 8, 2023 09:54
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
@obrix obrix requested a review from geofjamg November 9, 2023 09:38
@obrix obrix changed the title [WIP] Subnetwork support Subnetwork support Nov 9, 2023
@obrix
Copy link
Member Author

obrix commented Nov 9, 2023

@geofjamg Some tests from AbstractMergeNetworkTest like testMergeAndDetach are failing because of dangling line update. I haven't managed to find the reason yet.

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

80.4% 80.4% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant