Generic TopLevelDocument #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
…ess with tests and small edge cases handling Signed-off-by: Antoine Bouhours <[email protected]> Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
…ate to CollectionCache to avoid passing the same methods in CachedNetworkStoreClient for every call to CollectionCache Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
antoinebhs
changed the base branch from
main
to
lazy-loading-extension-attributes
|
3 tasks
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Antoine Bouhours <[email protected]>
jonenst
approved these changes
Aug 29, 2024
… into generic-topleveldocument
…lymorphic type information (for ExtensionAttributes) Signed-off-by: BOUHOURS Antoine <[email protected]>
…m/powsybl/powsybl-network-store into generic-topleveldocument
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
jonenst
approved these changes
Sep 2, 2024
…m/powsybl/powsybl-network-store into generic-topleveldocument
…m/powsybl/powsybl-network-store into generic-topleveldocument
antoinebhs
force-pushed
the
generic-topleveldocument
branch
from
47ff568 to
87c9eee
Compare
Signed-off-by: BOUHOURS Antoine <[email protected]>
SlimaneAmar
approved these changes
Sep 23, 2024
network-store-client/src/main/java/com/powsybl/network/store/client/RestClientImpl.java
Outdated
Show resolved
Hide resolved
…iceloader doesn't return them. Similar to https://github.com/powsybl/powsybl-core/blob/main/commons/src/main/java/com/powsybl/commons/extensions/ExtensionAdderProviders.java Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
antoinebhs
force-pushed
the
generic-topleveldocument
branch
from
a97c675 to
a370698
Compare
…m/powsybl/powsybl-network-store into generic-topleveldocument
Signed-off-by: BOUHOURS Antoine <[email protected]>
…m/powsybl/powsybl-network-store into generic-topleveldocument
antoinebhs
force-pushed
the
generic-topleveldocument
branch
from
b82b5ec to
3198454
Compare
… into generic-topleveldocument Signed-off-by: BOUHOURS Antoine <[email protected]>
antoinebhs
force-pushed
the
generic-topleveldocument
branch
from
3198454 to
ebaf86f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Create an abstraction for the class TopLevelDocument to have the possibility to create TopLevelDocument of anything (including for example resources, extension attributes).
What is the current behavior?
We can only create TopLevelDocument for resources (which is thus linked to IdentifiableAttributes).
What is the new behavior (if this is a feature change)?
The is one implementation of AbstractTopLevelDocument for resources (TopLevelDocument) and one for extensionAttributes ExtensionAttributesTopLevelDocument.
There is a need for an abstraction here as we can't use generics directly because of Jackson serialization not supporting generics at root level with polymorphic type information (see for example FasterXML/jackson-databind#699)
Does this PR introduce a breaking change or deprecate an API?