corrects Move connectable implementation in order to execute tcks on the network store server #447
Conversation
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
Signed-off-by: Mathieu DEHARBE <[email protected]>
| InjectionAttributes attr = attributesGetter.apply(res); | ||
| attr.setConnectableBus(busId); | ||
| attr.setBus(connected ? busId : null); | ||
| attr.setNode(null); |
There was a problem hiding this comment.
could you explain the reason to set null value for node in this case ?
There was a problem hiding this comment.
Because an equipment may be connected by Node (in node breaker view) of by bus (in bus breaker view). When you affect one of those values the other makes no sense anymore (and this may cause problems of you reaffect to the previous value, like in the unit tests).
However this brings a good question : may an equipment be connected to a bus and a node simultaneously in the same voltage level ? In the unit test the bus breaker view and the node breaker view were in different voltage levels so the previous value had to be nulled.
I don't really know the answer, what do you say @geofjamg ?
There was a problem hiding this comment.
Geoffroy told me that a voltage level can only be in node breaker OR bus breaker. Therefore it is impossible to be connected at the same to a node and to a bus in the same voltage level. And therefore setting the other to null should be fine.
| getAbstractIdentifiable().updateResource(res -> { | ||
| InjectionAttributes attr = attributesGetter.apply(res); | ||
| attr.setConnectableBus(null); | ||
| attr.setBus(null); |
There was a problem hiding this comment.
the same remarks for Bus and connectableBus
There was a problem hiding this comment.
and same answer as well.
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Corrects a bug in moveConnectable : the moved connectable wasn't correctly updated.
It will fix the tck tests executed here powsybl/powsybl-network-store-server#61
What is the current behavior?
The tests here powsybl/powsybl-network-store-server#61 have been overriden by an emtpy version that should be removed.
Does this PR introduce a breaking change or deprecate an API?