Fix notifications on terminal connection/disconnection #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/disconnect Remove some bus changing notifications Remove double call to opening/closing switches Fix bad return value of getConnectingSwitches method in TerminalImpl Signed-off-by: Franck LECUYER <[email protected]>
…erToInjectionAttributesAdapter class) Signed-off-by: Franck LECUYER <[email protected]>
TheMaskedTurtle
requested changes
Sep 24, 2024
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TerminalImpl.java
Outdated
Show resolved
Hide resolved
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TerminalImpl.java
Show resolved
Hide resolved
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TerminalImpl.java
Show resolved
Hide resolved
...om/powsybl/network/store/iidm/impl/ThreeWindingsTransformerToInjectionAttributesAdapter.java
Show resolved
Hide resolved
Signed-off-by: Franck LECUYER <[email protected]>
…on_terminal_connection_disconnection
FranckLecuyer
force-pushed
the
tck_fix_notification_on_terminal_connection_disconnection
branch
from
0e75b67 to
aafd1e0
Compare
|
TheMaskedTurtle
approved these changes
Sep 26, 2024
antoinebhs
deleted the
tck_fix_notification_on_terminal_connection_disconnection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Bug Fix
What is the current behavior?
Tck tests fail in ConnectionNotificationTest
What is the new behavior (if this is a feature change)?
Tck tests now succeed in ConnectionNotificationTest
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: